Fix publishing with optional dependencies. #8853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Eh2406 (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 2a07061 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 13, 2020
Update cargo Fixing an important publish bug. 2 commits in 8662ab427a8d6ad8047811cc4d78dbd20dd07699..2af662e22177a839763ac8fb70d245a680b15214 2020-11-12 03:47:53 +0000 to 2020-11-12 19:04:56 +0000 - Fix publishing with optional dependencies. (rust-lang/cargo#8853) - Minor typo in features.md (rust-lang/cargo#8851)
ehuss
pushed a commit
to ehuss/cargo
that referenced
this pull request
Nov 24, 2020
Fix publishing with optional dependencies. In rust-lang#8799, I neglected to update the `publish` code to use the correct features when generating the JSON to upload to the registry. The `Cargo.toml` file was correctly updated, but the JSON was not. This caused Cargo to send the implicit `dep:` feature syntax in the JSON blob, which crates.io rejects. The solution here is to use the original feature map before the implicit features have been added.
bors
added a commit
that referenced
this pull request
Nov 24, 2020
[beta] backport fix for publishing with optional dependencies. Beta backport of #8853.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #8799, I neglected to update the
publishcode to use the correct features when generating the JSON to upload to the registry. TheCargo.tomlfile was correctly updated, but the JSON was not. This caused Cargo to send the implicitdep:feature syntax in the JSON blob, which crates.io rejects. The solution here is to use the original feature map before the implicit features have been added.