Model function ABI in the Rust IR #481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AzureMarker
commented
May 28, 2020
bjorn3
reviewed
May 29, 2020
nikomatsakis
requested changes
May 29, 2020
There was a problem hiding this comment.
Can we add an abi field to the Fn type as well?
(Also, maybe we can rename that type to FnPointer, but that is I guess a distinct PR.)
jackh726
approved these changes
Jun 8, 2020
nikomatsakis
requested changes
Jun 9, 2020
|
One other thing, apparently a |
|
I kept the Fn ABI commit in the PR so the changes can be reused/referenced for future PRs. |
nikomatsakis
approved these changes
Jun 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #460
Only tracks function calling convention based on the discussion in the issue (though the interner could put more data in the
FnAbitype).