Skip to content

Refactor and flesh out Fn pointers #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jul 24, 2020
Merged

Refactor and flesh out Fn pointers #573

merged 12 commits into from
Jul 24, 2020

Conversation

nathanwhit
Copy link
Member

Closes #507.

This PR does a few things:

  • Renames Fn -> FnPointer
  • Adds ABI to FnPointer
  • Adds support for unsafe functions to both FnPointer and FnDef
  • Adds a variadic flag to both FnPointer and FnDef (cc this comment)

@nathanwhit nathanwhit changed the title Refactor and flesh out Fn Refactor and flesh out Fn pointers Jul 17, 2020
nikomatsakis
nikomatsakis requested changes Jul 17, 2020
View reviewed changes
Copy link
Contributor

@nikomatsakis nikomatsakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good! left some notes.

@nathanwhit
Copy link
Member Author

Addressed the comments, so this should be ready for re-review.

nikomatsakis
nikomatsakis requested changes Jul 20, 2020
View reviewed changes
jackh726
jackh726 approved these changes Jul 21, 2020
View reviewed changes
Copy link
Member

@jackh726 jackh726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. I'm good to merge this with or without the fn(...) syntax.

@jackh726
Copy link
Member

Okay this is as good as any of a PR to test out bors.

@bors r+

@jackh726
Copy link
Member

Welp that didn't work

@nathanwhit
Copy link
Member Author

@bors ping

@nathanwhit
Copy link
Member Author

@bors r=jackh726

@bors
Copy link
Contributor

bors commented Jul 24, 2020

📌 Commit ab2561a has been approved by jackh726

@bors
Copy link
Contributor

bors commented Jul 24, 2020

⌛ Testing commit ab2561a with merge dc18d1f...

bors added a commit that referenced this pull request Jul 24, 2020
@bors
Auto merge of #573 - nathanwhit:fn-refactor, r=jackh726
dc18d1f 
Refactor and flesh out Fn pointers

Closes #507.

This PR does a few things:
- Renames `Fn` -> `FnPointer`
- Adds ABI to `FnPointer`
- Adds support for unsafe functions to both `FnPointer` and `FnDef`
- Adds a variadic flag to both `FnPointer` and `FnDef` (cc [this comment](#507 (comment)))
@nathanwhit
Copy link
Member Author

@bors retry

@bors
Copy link
Contributor

bors commented Jul 24, 2020

⌛ Testing commit ab2561a with merge a07ccb1...

@bors
Copy link
Contributor

bors commented Jul 24, 2020

☀️ Test successful - checks-actions
Approved by: jackh726
Pushing a07ccb1 to master...

@bors bors merged commit a07ccb1 into rust-lang:master Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikomatsakis nikomatsakis nikomatsakis requested changes

@jackh726 jackh726 jackh726 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rename the Fn type to FnPointer
4 participants
@nathanwhit @jackh726 @bors @nikomatsakis