Skip to content

Pin cargo-workspaces to 0.2.44 #799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 30, 2023
Merged

Pin cargo-workspaces to 0.2.44 #799

merged 2 commits into from
Jun 30, 2023

Conversation

HKalbasi
Copy link
Member

The publish action was failing due some problem in the cargo-workspaces (see this zulip thread). The problem is now solved, so this PR is not necessary and just triggering the publish again should work, but this PR pin it to the current version to prevent similar problems in future.

@lqd
Copy link
Member

lqd commented Jun 30, 2023

An update of proc-macro2 will also be needed, to fix building on nightly.

@lqd
Copy link
Member

lqd commented Jun 30, 2023

Thanks! Hopefully it unblocks r-a if it's still needed.

(Let's see if bors is correctly set up for contributors.)

@bors r+

@bors
Copy link
Contributor

bors commented Jun 30, 2023

@lqd: 🔑 Insufficient privileges: Not in reviewers

@lqd
Copy link
Member

lqd commented Jun 30, 2023

We'll need the help of e.g. @compiler-errors 🙏

@compiler-errors
Copy link
Member

looks fine to me, hope this makes the release work ✅

@bors r+

@bors
Copy link
Contributor

bors commented Jun 30, 2023

📌 Commit ac7374f has been approved by compiler-errors

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jun 30, 2023

⌛ Testing commit ac7374f with merge 7e8d539...

@bors
Copy link
Contributor

bors commented Jun 30, 2023

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 7e8d539 to master...

@bors bors merged commit 7e8d539 into rust-lang:master Jun 30, 2023
@HKalbasi
Copy link
Member Author

@compiler-errors Can you also manually trigger the publish action?

@compiler-errors
Copy link
Member

compiler-errors commented Jun 30, 2023

I have no idea how to do that, or if I even have the permissions to do that. Maybe @jackh726 knows and can do it, but I think it's probably worth waiting a few days for the autopublish (it's on sundays, right?)

@HKalbasi
Copy link
Member Author

In https://github.com/rust-lang/chalk/actions/workflows/publish.yml you will see a Run workflow button if you have access:

image

But waiting on sunday is also fine, there is no hurry.

@compiler-errors
Copy link
Member

https://github.com/rust-lang/chalk/actions/runs/5425813938

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants