-
Notifications
You must be signed in to change notification settings - Fork 183
Pin cargo-workspaces to 0.2.44 #799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
An update of proc-macro2 will also be needed, to fix building on nightly. |
Thanks! Hopefully it unblocks r-a if it's still needed. (Let's see if bors is correctly set up for contributors.) @bors r+ |
@lqd: 🔑 Insufficient privileges: Not in reviewers |
We'll need the help of e.g. @compiler-errors 🙏 |
looks fine to me, hope this makes the release work ✅ @bors r+ |
☀️ Test successful - checks-actions |
@compiler-errors Can you also manually trigger the publish action? |
I have no idea how to do that, or if I even have the permissions to do that. Maybe @jackh726 knows and can do it, but I think it's probably worth waiting a few days for the autopublish (it's on sundays, right?) |
In https://github.com/rust-lang/chalk/actions/workflows/publish.yml you will see a But waiting on sunday is also fine, there is no hurry. |
The publish action was failing due some problem in the
cargo-workspaces
(see this zulip thread). The problem is now solved, so this PR is not necessary and just triggering the publish again should work, but this PR pin it to the current version to prevent similar problems in future.