Description
Proposal
Rename the type flags NEEDS_SUBST to HAS_PARAM and NEEDS_INFER to HAS_INFER. This is more consistent with the naming of HAS_TY_PARAM, HAS_CT_PARAM, HAS_RE_PARAM, HAS_TY_INFER, HAS_CT_INFER, HAS_RE_INFER flags.
NEEDS_SUBST just seems somewhat wrong, just because a type has params in it doesnt mean you should be calling subst on it, HAS_PARAM seems to reflect better what this is actually detecting.
Mentors or Reviewers
I will implement it myself, it should be simple to review
Process
The main points of the Major Change Process are as follows:
- File an issue describing the proposal.
- A compiler team member or contributor who is knowledgeable in the area can second by writing
@rustbot second.- Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a
-C flag, then full team check-off is required. - Compiler team members can initiate a check-off via
@rfcbot fcp mergeon either the MCP or the PR.
- Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a
- Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.
You can read more about Major Change Proposals on forge.
Comments
This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.