Skip to content

Expose default_hidden_visibility as a rustc command line option #656

Closed
@bridiver

Description

@bridiver

Proposal

I would like to expose default-hidden-visibility https://github.com/rust-lang/rust/blob/d3515155216e98c23440ea92c3f49c6a0d7101fc/compiler/rustc_target/src/spec/mod.rs#L1877C9-L1877C34 as a rustc unstable command line option. The problem we're trying to solve is that we have a mixed cpp/rust framework for mac/ios that needs to export symbols for various apis, but we do not want to expose all the core rust apis which are default visible. I have already built rust locally with the required changes and verified that setting default_hidden_visibility works as expected and the only exported symbols are the cpp symbols that are intended to be exported (no rust symbols are exported). There does not appear to be any other way to the equivalent of -fvisibility=hidden.

Mentors or Reviewers

@bridiver

Process

The main points of the Major Change Process are as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    T-compilerAdd this label so rfcbot knows to poll the compiler teammajor-changeA proposal to make a major change to rustcmajor-change-acceptedA major change proposal that was accepted

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions