Skip to content

Policy: Require MCP and relevant team nominations for adding (ecosystem, custom codegen backend) testing jobs that would block PR/Merge CI and require documenting failure protocol #845

Closed
@jieyouxu

Description

@jieyouxu

Proposal

New policy: Require compiler MCP and a library team review for adding new ecosystem/integration test jobs/components to rust-lang/rust CI

The policy draft is at rust-lang/rust-forge#813. Please leave review feedback against that PR for the policy wording / details.

This policy is retroactive for existing ecosystem/integration test jobs/components

This requirement is intended to be retroactive. I will file MCPs for the existing ecosystem/integration test jobs/components (or at least partially; we will need to work with the ecosystem/integration test job/component maintainers to fill the details out). If they are accepted, then no actions need to be done. If there are outstanding blocking concerns, then we may modify or remove the existing ecosystem/integration test jobs/components if the concerns are substantial and cannot be resolved in a timely fashion (as a last resort).

Mentors or Reviewers

@davidtwco and @wesleywiser

This should also be discussed with T-{rustdoc,infra,bootstrap,libs} members.

Process

The main points of the Major Change Process are as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Metadata

Metadata

Assignees

No one assigned

    Labels

    T-compilerAdd this label so rfcbot knows to poll the compiler teammajor-changeA proposal to make a major change to rustcmajor-change-acceptedA major change proposal that was accepted

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions