Skip to content

Add "compilers" category. #2983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 7, 2021
Merged

Add "compilers" category. #2983

merged 4 commits into from
Feb 7, 2021

Conversation

mental32
Copy link
Contributor

@mental32 mental32 commented Oct 30, 2020

Sub categories include: transpilers, interpreters, and compilers.

I decided to follow the precedence set by "parser-implementations" and "parsing" for these categories since they felt appropriately related.

Resolves #1412

Sub categories include: transpilers, interpreters, and compilers.
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @carols10cents (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

Copy link
Member

@Turbo87 Turbo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll discuss this one last time on the weekly on Friday and then we can hopefully have this merged :)

@mental32 mental32 changed the title Add "language-implementations" category and sub-categories. Add "compilers" category. Feb 3, 2021
@Turbo87
Copy link
Member

Turbo87 commented Feb 5, 2021

@mental32 we just discussed this and will merge this in the next days. since a change like this will make the rollback of a bad deployment harder we would like to first deploy the other queued up changes before merging this. :)

@Turbo87
Copy link
Member

Turbo87 commented Feb 7, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Feb 7, 2021

📌 Commit 0ea4e15 has been approved by Turbo87

@bors
Copy link
Contributor

bors commented Feb 7, 2021

⌛ Testing commit 0ea4e15 with merge bf22455...

@bors
Copy link
Contributor

bors commented Feb 7, 2021

☀️ Test successful - checks-actions
Approved by: Turbo87
Pushing bf22455 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a new category for "language interpreters, compilers or run-times"
5 participants