-
Notifications
You must be signed in to change notification settings - Fork 645
Add "compilers" category. #2983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Sub categories include: transpilers, interpreters, and compilers.
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @carols10cents (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Co-authored-by: Tobias Bieniek <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we'll discuss this one last time on the weekly on Friday and then we can hopefully have this merged :)
@mental32 we just discussed this and will merge this in the next days. since a change like this will make the rollback of a bad deployment harder we would like to first deploy the other queued up changes before merging this. :) |
@bors r+ |
📌 Commit 0ea4e15 has been approved by |
☀️ Test successful - checks-actions |
Sub categories include: transpilers, interpreters, and compilers.
I decided to follow the precedence set by
"parser-implementations"
and"parsing"
for these categories since they felt appropriately related.Resolves #1412