tests/krate/publish: Fix new_krate_tarball_with_hard_links()
#3065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
force-pushed
the
fix-hard-link-test
branch
from
2c5bb50 to
d99f1ea
Compare
|
☔ The latest upstream changes (presumably #3066) made this pull request unmergeable. Please resolve the merge conflicts. Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels: |
Turbo87
force-pushed
the
fix-hard-link-test
branch
from
d99f1ea to
e9df5ba
Compare
The test was receiving "too large when decompressed" because of a broken header checksum, which was mistakenly converted into this error message, because we assume that every `entries()` error is coming from our `LimitErrorReader`. This commit moves the checksum calculation to the right place, which causes the test to now test the correct condition in our `verify_tarball()` function.
Turbo87
force-pushed
the
fix-hard-link-test
branch
from
e9df5ba to
f3469ed
Compare
|
@bors r+ |
|
📌 Commit f3469ed has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test was receiving "too large when decompressed" because of a broken header checksum, which was mistakenly converted into this error message, because we assume that every
entries()error is coming from ourLimitErrorReader. This commit moves the checksum calculation to the right place, which causes the test to now test the correct condition in ourverify_tarball()function.r? @pietroalbini