Use new conduit API when computing elapsed time #3156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The request start time is now captured by a `conduit` based server. This ensures that the logged elapsed time is accurate, even if the request queues waiting for a background thread to run on.
|
LGTM 👍 @bors r+ |
|
📌 Commit a4df38e has been approved by |
|
☀️ Test successful - checks-actions |
bors
added a commit
that referenced
this pull request
Jan 14, 2021
Bump conduit-hyper to ensure request start time is tracked I forgot to publish the new conduit-hyper, which now adds `StartInstant` to the request extensions. conduit-rust/conduit-hyper@v0.3.0-alpha.6...v0.3.0-alpha.7 - See also #3156 which backported this to `alpha.5.1`. r? `@Turbo87`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The request start time is now captured by a
conduitbased server. Thisensures that the logged elapsed time is accurate, even if the request
queues waiting for a background thread to run on.
Relevent upstream changes:
Unrelated upstream changes (minor API cleanup):
r? @Turbo87
cc @pietroalbini