Skip to content

EncodableCrate: Add max_stable_version field #3163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 7, 2021
Merged

EncodableCrate: Add max_stable_version field #3163

merged 3 commits into from
Jan 7, 2021

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Jan 5, 2021

This PR resolves the API part of #654 by adding a max_stable_version field for the krate resource. Since naming is hard, it is called highest_stable internally on the TopVersions struct. Contrary to newest_version and max_version this field will be null (not "0.0.0") if all available versions have been yanked.

r? @jtgeibel

@Turbo87 Turbo87 added the C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works label Jan 5, 2021
jtgeibel
jtgeibel reviewed Jan 5, 2021
View reviewed changes
@jtgeibel
Copy link
Member

jtgeibel commented Jan 7, 2021

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Jan 7, 2021

📌 Commit 9bad2a6 has been approved by jtgeibel

@bors
Copy link
Contributor

bors commented Jan 7, 2021

⌛ Testing commit 9bad2a6 with merge 13fdc94...

@bors
Copy link
Contributor

bors commented Jan 7, 2021

☀️ Test successful - checks-actions
Approved by: jtgeibel
Pushing 13fdc94 to master...

@bors bors merged commit 13fdc94 into rust-lang:master Jan 7, 2021
@Turbo87 Turbo87 deleted the top-versions branch January 7, 2021 01:19
@Turbo87 Turbo87 mentioned this pull request Jan 9, 2021
Merged
bors added a commit that referenced this pull request Jan 11, 2021
@bors
Auto merge of #3169 - Turbo87:top-versions-mirage, r=pichfl
d7800dd 
mirage/crate: Add derived `max_stable_version` field

This PR implements #3163 for our fake testing API on the frontend to eventually address #654

r? `@pichfl`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtgeibel jtgeibel jtgeibel left review comments

Assignees

@jtgeibel jtgeibel

Labels
C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Turbo87 @jtgeibel @bors @rust-highfive