Skip to content

Remove obsolete failure dependency #3182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 15, 2021
Merged

Remove obsolete failure dependency #3182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11c5382
controllers::user::session: Remove obsolete `failure` conversion
Turbo87 Jan 15, 2021
fea49c9
Remove unused `failure` dependency
Turbo87 Jan 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 0 additions & 35 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ dialoguer = "0.7.1"
diesel = { version = "1.4.0", features = ["postgres", "serde_json", "chrono", "r2d2"] }
diesel_full_text_search = "1.0.0"
dotenv = "0.15"
failure = "0.1.1"
flate2 = "1.0"
futures-channel = { version = "0.3.1", default-features = false }
futures-util = "0.3"
Expand Down
2 changes: 0 additions & 2 deletions src/controllers/user/session.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ use crate::controllers::frontend_prelude::*;

use crate::github;
use conduit_cookie::RequestSession;
use failure::Fail;
use oauth2::reqwest::http_client;
use oauth2::{AuthorizationCode, Scope, TokenResponse};

Expand Down Expand Up @@ -99,7 +98,6 @@ pub fn authorize(req: &mut dyn RequestExt) -> EndpointResult {
.github
.exchange_code(code)
.request(http_client)
.map_err(|e| e.compat())
.chain_error(|| server_error("Error obtaining token"))?;
let token = token.access_token();

Expand Down