Update debug middleware #3440
Merged
Update debug middleware #3440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This hasn't been used in years, and I'm not sure it would be helpful with current production traffic (concurrent requests can interleave their output). We should be able to build out something more targed with `tracing`.
All this output is annoying during local development, and can be easily accessed if necessary via the `RUST_LOG` environment variable.
|
@bors r+ seems like a good idea :) any thoughts on making the environment check a compile-time flag? |
|
📌 Commit 6a602e6 has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit drops the ability to enable this middleware on production. With current traffic levels this isn't very practical (as concurrent requests can interleave their output), and we don't want to log headers that may contain authorization cookies or tokens.
The second commit silences the debug information by default during local development. It can be re-enabled by setting the
RUST_LOGenvironment variable appropriately.r? @Turbo87