Skip to content

Add FORCE_UNCONDITIONAL_REDIRECTS #3884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

pietroalbini
Copy link
Member

This PR adds a new environment variable, FORCE_UNCONDITIONAL_REDIRECTS, which forces unconditional redirects even with a fully healthy database. The environment variable is meant to be used by an on-call operator to reduce the database load when the primary database is overloaded, and should only be set during incidents.

@pietroalbini
Copy link
Member Author

I recommend using this link for the review, as that hides whitespace-only changes (the bulk of the changes, as I had to change the indentation of most of the download endpoint).

Copy link
Member

@Turbo87 Turbo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

feel free to r=me

@pietroalbini
Copy link
Member Author

@bors r=Turbo87

@bors
Copy link
Contributor

bors commented Sep 3, 2021

📌 Commit 6da09d3 has been approved by Turbo87

@bors
Copy link
Contributor

bors commented Sep 3, 2021

⌛ Testing commit 6da09d3 with merge 227f109...

@bors
Copy link
Contributor

bors commented Sep 3, 2021

☀️ Test successful - checks-actions
Approved by: Turbo87
Pushing 227f109 to master...

@bors bors merged commit 227f109 into rust-lang:master Sep 3, 2021
@Turbo87 Turbo87 added A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear labels Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants