Split DB_POOL_SIZE & DB_MIN_IDLE environment variables #3922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves the configuration of `DB_POOL_SIZE` into the `DbPoolConfig` struct.
The change splits the environment variable `DB_POOL_SIZE` into two separate ones, `DB_PRIMARY_POOL_SIZE` set in the primary database, `DB_REPLICA_POOL_SIZE` in the replica database. * refactor db configuration in App
Similar to env vars `DB_PRIMARY_POOL_SIZE` and `DB_REPLICA_POOL_SIZE` the variable `DB_MIN_IDLE` moved to the `full_from_environment` function.
The change splits the `DB_MIN_IDLE` into `DB_PRIMARY_MIN_IDLE` & `DB_REPLICA_MIN_IDLE` to configure both primary and replica differently.
* set primary db pool size in middleware * set db pool sizes in test environment
Turbo87
added
A-backend ⚙️
C-internal 🔧
|
Thanks! @bors r+ |
|
📌 Commit dd14199 has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits the existing environment variables
DB_POOL_SIZE&DB_MIN_IDLEinto separate variables to provide different connection settings to the primary & replica databases. The main reason for this change is to be able to configure different values for both database pools.The new env variables are:
DB_PRIMARY_POOL_SIZE&DB_REPLICA_POOL_SIZEto configure the number of connections in the primary & replica poolDB_PRIMARY_MIN_IDLE&DB_REPLICA_MIN_IDLEto set the number of idle connections each pool at least maintainsNote the descriptions of the
*_POOL_SIZEvariables inapp.jsonare most likely off & need correct wording.