middleware::log_request: Move OriginalPath code into NormalizePath middleware
#4124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
C-internal 🔧
JohnTitor
approved these changes
Nov 5, 2021
Turbo87
force-pushed
the
original-path
branch
from
8c6736a to
362f80d
Compare
|
@bors r=JohnTitor |
|
📌 Commit 362f80d has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
NormalizePathmiddleware is the one that mutates thepath, so it should also be responsible for saving the original one, if necessary.This PR slightly changes the logic in that
OriginalPathis only added to the request extensions if the path has been changed. TheNormalizePathmiddleware now defaults torequest.path(), ifOriginalPathis not found in the request extensions.