Skip to content

catch-all: Fix broken "Go back" and "Reload" links #4314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 22, 2021
Merged

catch-all: Fix broken "Go back" and "Reload" links #4314

merged 3 commits into from
Dec 22, 2021

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Dec 22, 2021

Refused to run the JavaScript URL because it violates the following Content Security Policy directive: "script-src 'self' 'unsafe-eval' 'sha256-n1+BB7Ckjcal1Pr7QNBh/dKRTtBQsIytFodRiIosXdE='". Either the 'unsafe-inline' keyword, a hash ('sha256-...'), or a nonce ('nonce-...') is required to enable inline execution. Note that hashes do not apply to event handlers, style attributes and javascript: navigations unless the 'unsafe-hashes' keyword is present.

This PR fixes the above error, that is triggered from hitting the "Go back" link on e.g. https://crates.io/crates/jdfgkjsdfjksnd

@Turbo87 Turbo87 added A-frontend 🐹 C-bug 🐞 Category: unintended, undesired behavior labels Dec 22, 2021
@Turbo87 Turbo87 mentioned this pull request Dec 22, 2021
Merged
@Turbo87
Copy link
Member Author

Turbo87 commented Dec 22, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Dec 22, 2021

📌 Commit a21b0a2 has been approved by Turbo87

@bors
Copy link
Contributor

bors commented Dec 22, 2021

⌛ Testing commit a21b0a2 with merge 9fbb03c...

@bors
Copy link
Contributor

bors commented Dec 22, 2021

☀️ Test successful - checks-actions
Approved by: Turbo87
Pushing 9fbb03c to master...

@bors bors merged commit 9fbb03c into rust-lang:master Dec 22, 2021
@Turbo87 Turbo87 deleted the fix-back-link branch December 22, 2021 20:49
bors added a commit that referenced this pull request Dec 23, 2021
@bors
Auto merge of #4315 - Turbo87:please-authenticate, r=Turbo87
cdab896 
Show "This page requires authentication" page for protected routes if unauthenticated

<img width="1008" alt="Bildschirmfoto 2021-12-22 um 20 02 10" src="https://user-images.githubusercontent.com/141300/147142321-1f56d28c-6a3c-4751-aefa-2d1e84bdb934.png">

Resolves #3687

~Note that this is based on #4314 and includes those commits to avoid merge conflicts.~
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-frontend 🐹 C-bug 🐞 Category: unintended, undesired behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Turbo87 @bors