Skip to content

Social media tags #5177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

elpiel
Copy link
Contributor

@elpiel elpiel commented Sep 1, 2022

Related to #5176 I've decided to open a WIP PR for adding some initial tags and to drive the discussion on how to implement this feature.

@Turbo87
Copy link
Member

Turbo87 commented Sep 2, 2022

the main issue with this is that we don't use server-side rendering of the HTML. for Google indexing this is fine, but pages like Twitter don't execute the JS rendering code, so just adding the tags is unfortunately not enough for them to actually be useful in the current setup. there have been some attempts to use server-side rendering with the JS code, but last time it was tried I think it caused excessive load on our servers so it was disabled again.

@elpiel
Copy link
Contributor Author

elpiel commented Sep 2, 2022

If I understand correctly, this, with the current setup, is challenging to do?!
Should we leave the discussion to see what could be other solutions for this? E.g. Some sort of proxy for when twitter requests the webpage

@Turbo87 Turbo87 added C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works A-frontend 🐹 labels Sep 9, 2022
@Turbo87
Copy link
Member

Turbo87 commented Sep 9, 2022

If I understand correctly, this, with the current setup, is challenging to do?!

unfortunately, yes. unless we want to pay a lot more for more powerful servers it will most likely not happen anytime soon.

E.g. Some sort of proxy for when twitter requests the webpage

yeah, some sort of redirect for well known user-agents might be an option. I think we're serving our frontend behind AWS CloudFront though, so that might have to be taken into account in any solution proposal.

Should we leave the discussion to see what could be other solutions for this?

Sure, yeah, the discussion can stay open as a long-term feature request, but I would propose to close the PR, since this is unlikely to be solve in the near-term future.

@elpiel elpiel closed this Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend 🐹 C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants