Upgrade rusoto (and tokio) #1264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolreader18
force-pushed
the
upgrade-rusoto
branch
from
ac58356 to
932fb1b
Compare
jyn514
reviewed
Feb 4, 2021
There was a problem hiding this comment.
This has compile errors. Also tokio 0.2 is still in the dependency tree, I'd prefer not to update until that's fixed.
> cargo tree -i tokio:0.2.22
tokio v0.2.22
├── h2 v0.2.5
│ └── hyper v0.13.6
│ ├── hyper-tls v0.4.1
│ │ └── reqwest v0.10.10
│ │ └── rustwide v0.11.0
│ │ └── docs-rs v0.6.0 (/home/joshua/src/rust/docs.rs)
│ └── reqwest v0.10.10 (*)
├── hyper v0.13.6 (*)
├── hyper-tls v0.4.1 (*)
├── postgres v0.17.5
│ └── schemamama_postgres v0.3.0
│ └── docs-rs v0.6.0 (/home/joshua/src/rust/docs.rs)
├── reqwest v0.10.10 (*)
├── rustwide v0.11.0 (*)
├── tokio-postgres v0.5.5
│ └── postgres v0.17.5 (*)
├── tokio-tls v0.3.1
│ ├── hyper-tls v0.4.1 (*)
│ └── reqwest v0.10.10 (*)
└── tokio-util v0.3.1
├── h2 v0.2.5 (*)
└── tokio-postgres v0.5.5 (*)
|
@jyn514 are you sure you're on the right branch? I got rid of all the instances of tokio 0.2 in the dep tree I'm pretty sure, |
|
Oh hmm something is fishy then - cherry-picking your changes to Cargo.toml and running |
|
Huh, that's really strange. I just ran cargo update, I didn't do anything fancy. Do you want to try with the latest commit? I bumped rustwide in Cargo.toml, maybe that would have something to do with it |
|
|
Ok, I see - Can you separate the |
|
If you can post the output from |
coolreader18
force-pushed
the
upgrade-rusoto
branch
from
5e62909 to
94daab5
Compare
|
I've separated the commits, I think the main one that was breaking things was |
|
Thanks. These were the versions changed: and the number of duplicates went down from 23 to 16 which is definitely a step in the right direction :)
By the way, 0.13 -> 0.14 is not a minor version bump because it's before 1.0, it's a major bump (which is why you had to change Cargo.toml). |
jyn514
added
the
S-waiting-on-deploy
|
Right, that's what I meant, semver incompatible I guess. |
syphar
removed
the
S-waiting-on-deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1102
The new rusoto version also updates tokio, so this is a WIP of upgrading that.
Currently waiting on rust-lang/rustwide#51