Skip to content

Cleanup unneeded JS #1314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 31, 2021
Merged

Cleanup unneeded JS #1314

merged 3 commits into from
Mar 31, 2021

Conversation

notriddle
Copy link
Contributor

No description provided.

@notriddle
Remove outdated workaround for rustdoc scrolling
cf11a48 
It used to be that the <DIV CLASS="rustdoc"> had `overflow: auto` on it,
so when a menu was closed, we needed to focus it to make sure keyboard
scrolling worked. It doesn't work that way any more, so the workaround
is dead code.
jyn514
jyn514 approved these changes Mar 22, 2021
View reviewed changes
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the nit fixed, sorry for the delay reviewing.

@jyn514 jyn514 added A-frontend Area: Web frontend C-technical-debt Category: This makes the code harder to read and modify, but has no impact on end users S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Mar 22, 2021
@notriddle
Update templates/core/home.html
d7d7236 
Co-authored-by: Joshua Nelson <[email protected]>
@notriddle
Copy link
Contributor Author

I fixed your nit. Is it mergeable now?

@jyn514
Copy link
Member

jyn514 commented Mar 31, 2021

Yes, thank you!

@jyn514 jyn514 merged commit da87867 into rust-lang:master Mar 31, 2021
@notriddle notriddle deleted the clean-js branch August 14, 2022 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyn514 jyn514 jyn514 approved these changes

Assignees
No one assigned
Labels
A-frontend Area: Web frontend C-technical-debt Category: This makes the code harder to read and modify, but has no impact on end users S-waiting-on-author Status: This PR is incomplete or needs to address review comments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@notriddle @jyn514