-
Notifications
You must be signed in to change notification settings - Fork 212
templates/about: mention that "dependencies" key isn't being used yet #318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adding a comment that the `dependencies` key in the `package.metadata.docs.rs` key isn't yet used for builds should clear up some confusion.
Co-Authored-By: decathorpe <[email protected]>
I'm not a native speaker, so suggestions for improvements are welcome :) |
I wasn't planning to add/show this feature until we start using it, and we will start using it soon. |
But it IS already documented here, which is leading to confusion: https://docs.rs/about 🤔 |
Would you rather we remove the entry entirely from these docs? As @decathorpe mentioned, it is currently being shown on the "About" page. |
Yes looks like its been added with #196, I didn't realize dependencies until this PR sorry 🤢 It's better if we remove that section until we start using it. |
Revisiting this PR. I agree with #318 (comment) - it's best to remove it from documentation entirely until it becomes useful. Can you update the file to remove that entry from the page? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much!
And it's live! https://docs.rs/about |
Thanks! 😄 |
Adding a comment that the
dependencies
key in thepackage.metadata.docs.rs
key isn't yet used for builds should clear up some confusion.