Skip to content

Documentation - Mention rust backend & update miniz and flate info #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2017
Merged

Documentation - Mention rust backend & update miniz and flate info #130

merged 1 commit into from
Oct 23, 2017

Conversation

oyvindln
Copy link
Contributor

@oyvindln oyvindln commented Oct 23, 2017

Note that there is now a rust back-end. (Granted a version with it hasn't been published yet so I don't know if this should be changed until that's ready.)

Point the miniz link to the new github page instead of the removed google code one.

Mention that the flate library is no longer part of the rust compiler, and fix the link so it doesn't point to the wrong library.
The libflate library on crates.io is a different library so I removed the lib prefix in the documentation here to avoid confusion.

Not sure if a link to flate is really needed but I did a simple replacement for now.

Note that there is now a rust back-end.

Point the miniz link to the new github page instead of the removed google code one.

Mention that the flate library is no longer part of the rust compiler, and fix the link so it doesn't point to the wrong library.
(the libflate library on crates.io is a different library.)
@oyvindln
Copy link
Contributor Author

Also, as miniz_oxide uses break with value a fair bit, using the rust back-end requires at least rust 1.19. Should I put that in the readme as well?

@alexcrichton
Copy link
Member

Nah I think it's ok to not worry too much about the version requirements here, this otherwise looks great to me, thanks!

@alexcrichton alexcrichton merged commit 434490f into rust-lang:master Oct 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants