This repository was archived by the owner on Mar 14, 2023. It is now read-only.
Add thomcc as a reviewer for std::sys::windows
#425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been reviewing patches in it for @ChrisDenton in this module for a while, and have plenty of background with windows programming from earlier in my career (although until recently it was pretty rusty). I also recently went through this module looking for issues (hence the PRs fixing alignment/uninit/zeroing/widening) and feel comfortable reviewing changes to it.
This also avoids cases like rust-lang/rust#101481 (comment) in the future, as now it has two reviewers (although it seems a little bit like a bug that it doesn't fall back to the rule for library/std in that case).