Undo division of in6_addr on Fuchsia #1069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was broken out into a separate type to match the native representation on Fuchsia in https://github.com/rust-lang/libc/pull/1067/files, but it caused a breakage in libstd/net/addr.rs because some platform-independent code was expecting to be able to access the fields of this struct directly. In order to avoid introducing new
cfgs into the codebase, this change is being rolled back (especially since the two forms should be equivalent in how the wrapping struct is passed via the C ABI).r? @alexcrichton