Skip to content

Add IP_RECVIF to BSD and IP_RECVDSTADDR to apple. #1184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 28, 2018
Merged

Add IP_RECVIF to BSD and IP_RECVDSTADDR to apple. #1184

merged 1 commit into from
Dec 28, 2018

Conversation

pusateri
Copy link
Contributor

FreeBSD/OpenBSD do not support IP_PKTINFO for IPv4 but use IP_RECVIF for interface index and IP_RECVDSTADDR for destination address.
NetBSD and macOS also support IP_RECVIF and IP_RECVDSTADDR in addition to IP_PKTINFO.
(For IPv6, all use IPV6_PKTINFO)

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@gnzlbg
Copy link
Contributor

gnzlbg commented Dec 28, 2018

@bors: r+

@bors
Copy link
Contributor

bors commented Dec 28, 2018

📌 Commit 3229fca has been approved by gnzlbg

@bors
Copy link
Contributor

bors commented Dec 28, 2018

⌛ Testing commit 3229fca with merge 7b3d2c6...

bors added a commit that referenced this pull request Dec 28, 2018
Add IP_RECVIF to BSD and IP_RECVDSTADDR to apple.

FreeBSD/OpenBSD do not support IP_PKTINFO for IPv4 but use IP_RECVIF for interface index and IP_RECVDSTADDR for destination address.
NetBSD and macOS also support IP_RECVIF and IP_RECVDSTADDR in addition to IP_PKTINFO.
(For IPv6, all use IPV6_PKTINFO)
@bors
Copy link
Contributor

bors commented Dec 28, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: gnzlbg
Pushing 7b3d2c6 to master...

@bors bors merged commit 3229fca into rust-lang:master Dec 28, 2018
@pusateri pusateri deleted the recvif branch December 28, 2018 10:55
bors added a commit that referenced this pull request Jan 2, 2019
Add IP_RECVDSTADDR on netbsd.

Accidentally left out IP_RECVDSTADDR on NetBSD in #1184
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants