Add support for the accept4 system call for FreeBSD* & NetBSD*
#546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
It looks like rumprun may not have accept4? |
|
As I said, support for |
|
Yeah let's just move it down for now. |
|
Done! Also, out of curiosity, is BitRig still a thing or have they stalled after their initial release? |
|
I'm not sure myself unfortunately :( Looks great though! @bors: r+ |
|
📌 Commit 23d4059 has been approved by |
bors
added a commit
that referenced
this pull request
Mar 3, 2017
Add support for the `accept4` system call for FreeBSD* & NetBSD* As outlined in #540. However since support for this system call seems to be committed, but not yet released in NetBSD & BitRig (is BitRig actually still be developed at all, btw?), I'm not sure whether it wouldn't be a better idea to only add OpenBSD support instead? What's the official policy on this?
|
☀️ Test successful - status-appveyor, status-travis |
Susurrus
pushed a commit
to Susurrus/libc
that referenced
this pull request
Mar 26, 2017
Release v0.8.0 closes rust-lang#519
danielverkamp
pushed a commit
to danielverkamp/libc
that referenced
this pull request
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As outlined in #540.
However since support for this system call seems to be committed, but not yet released in NetBSD & BitRig (is BitRig actually still be developed at all, btw?), I'm not sure whether it wouldn't be a better idea to only add OpenBSD support instead?
What's the official policy on this?