Skip to content
This repository was archived by the owner on Feb 5, 2019. It is now read-only.

[WebAssembly] Teach fast-isel to gracefully recover from illegal retu… #112

Merged
merged 1 commit into from
May 7, 2018
Merged

[WebAssembly] Teach fast-isel to gracefully recover from illegal retu… #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions lib/Target/WebAssembly/WebAssemblyFastISel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -698,8 +698,12 @@ bool WebAssemblyFastISel::fastLowerArguments() {
for (auto const &Arg : F->args())
MFI->addParam(getLegalType(getSimpleType(Arg.getType())));

if (!F->getReturnType()->isVoidTy())
MFI->addResult(getLegalType(getSimpleType(F->getReturnType())));
if (!F->getReturnType()->isVoidTy()) {
MVT::SimpleValueType RetTy = getSimpleType(F->getReturnType());
if (RetTy == MVT::INVALID_SIMPLE_VALUE_TYPE)
return false;
MFI->addResult(getLegalType(RetTy));
}

return true;
}
Expand Down
16 changes: 16 additions & 0 deletions test/CodeGen/WebAssembly/fast-isel-i24.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
; RUN: llc < %s -O0
; PR36564

; Test that fast-isel properly copes with i24 arguments and return types.

target datalayout = "e-m:e-p:32:32-i64:64-n32:64-S128"
target triple = "wasm32-unknown-unknown-wasm"

define i24 @add(i24 %x, i24 %y) {
%z = add i24 %x, %y
ret i24 %z
}

define i24 @return_zero() {
ret i24 0
}