This repository was archived by the owner on Feb 5, 2019. It is now read-only.
Archives require a symbol table on Solaris, even if empty. #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Solaris ld (and some other tools that use the underlying utility libraries, such as elfdump) chokes on an archive library that has no symbol table. The Solaris tools always create one, even if it's empty. That bug has been fixed in the latest development line, and can probably be backported to a supported release, but it would be nice if LLVM's archiver could emit the empty symbol table, too. Fixed in upstream LLVM in revision 297773.
|
Thanks for the PR! I'm having trouble finding the commit upstream, you wouldn't happen to have the sha on hand would you? |
|
Looks like it's 22bd70f in the llvm-mirror repo on github. |
|
Oh oops sorry I was looking at the wrong git remote! |
TimNN
pushed a commit
to TimNN/llvm
that referenced
this pull request
Apr 17, 2017
Archives require a symbol table on Solaris, even if empty.
TimNN
pushed a commit
that referenced
this pull request
Apr 23, 2017
Archives require a symbol table on Solaris, even if empty.
arielb1
pushed a commit
that referenced
this pull request
Jun 27, 2017
Archives require a symbol table on Solaris, even if empty.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Solaris ld (and some other tools that use the underlying utility
libraries, such as elfdump) chokes on an archive library that has no
symbol table. The Solaris tools always create one, even if it's empty.
That bug has been fixed in the latest development line, and can
probably be backported to a supported release, but it would be nice if
LLVM's archiver could emit the empty symbol table, too.
Fixed in upstream LLVM in revision 297773.