Skip to content
This repository was archived by the owner on Feb 5, 2019. It is now read-only.

Fix computeKnownBits for ARMISD::CMOV #67

Merged
merged 1 commit into from
Mar 23, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/Target/ARM/ARMISelLowering.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -10806,8 +10806,8 @@ static void computeKnownBits(SelectionDAG &DAG, SDValue Op, APInt &KnownZero,
if (Op.getOpcode() == ARMISD::CMOV) {
APInt KZ2(KnownZero.getBitWidth(), 0);
APInt KO2(KnownOne.getBitWidth(), 0);
computeKnownBits(DAG, Op.getOperand(1), KnownZero, KnownOne);
computeKnownBits(DAG, Op.getOperand(2), KZ2, KO2);
computeKnownBits(DAG, Op.getOperand(0), KnownZero, KnownOne);
computeKnownBits(DAG, Op.getOperand(1), KZ2, KO2);

KnownZero &= KZ2;
KnownOne &= KO2;
Expand Down
19 changes: 19 additions & 0 deletions test/CodeGen/ARM/no-cmov2bfi.ll
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
; RUN: llc < %s -mtriple=thumbv7 | FileCheck --check-prefix=CHECK-NOBFI %s

declare zeroext i1 @dummy()

define i8 @test(i8 %a1, i1 %c) {
; CHECK-NOBFI-NOT: bfi
; CHECK-NOBFI: bl dummy
; CHECK-NOBFI: cmp r0, #0
; CHECK-NOBFI: it ne
; CHECK-NOBFI: orrne [[REG:r[0-9]+]], [[REG]], #8
; CHECK-NOBFI: mov r0, [[REG]]

%1 = and i8 %a1, -9
%2 = select i1 %c, i8 %1, i8 %a1
%3 = tail call zeroext i1 @dummy()
%4 = or i8 %2, 8
%ret = select i1 %3, i8 %4, i8 %2
ret i8 %ret
}