-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat: keyboard shortcut to toggle sidebar #2343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: keyboard shortcut to toggle sidebar #2343
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have liked to do this in https://github.com/rust-lang/mdBook/blob/master/src/theme/book.js#L443, but for some reason this keyboard shortcut wasn't working there, while the click
handler worked without issue.
@Dylan-DPC I tried to do this in a cleaner way with hamirmahal@a7da1d0, but |
This comment has been minimized.
This comment has been minimized.
1d44c61
to
1dda4d3
Compare
1dda4d3
to
e744bc2
Compare
With this changeWith this pull request, users would be able to collapse, and expand, the sidebar with just their keyboard. 2025-05-10_15.59.49.mp4 |
@ehuss are there any changes you'd like me to make here? I fixed the merge conflicts. It's been around 414 days or so since I opened this pull request. I'm hoping we can get it across the finish line. |
@y21 would you happen to know how I can get feedback from I think this feature could make life easier for a lot of |
Sorry, I don't know about the reviewing process in this repo here, usually (at least in clippy and the Rust repo) the standard wait time is 14 days, at which point a reviewer can be rerolled with This does look like a useful feature though 👍 |
closes #2342.