-
Notifications
You must be signed in to change notification settings - Fork 1.7k
refactor: Use axum for "mdbook serve" #2359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
FWIW this seems the right call, as |
rebased, squashed commits; upgraded to axum 0.8.1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the change raising msrv to 1.75 should be removed from the PR.
Especially as mdbook is now on 1.77 already.
Thanks for the update. I am not familiar with axum so I can't comment on the code, but I tried the PR locally and it works on Linux. My only thought was that by replacing a small framework with a larger one we might make the executable much larger.
So somehow this change also reduces the size of the executable by some 13%. Any idea how and why? |
Speculation:
|
This comment has been minimized.
This comment has been minimized.
☔ The latest upstream changes (possibly 9822c2a) made this pull request unmergeable. Please resolve the merge conflicts. |
This in my opinion brings mdbook's dependencies more in line with "the state of the art" of the Rust HTTP ecosystem.
It pulls in
hyper v1
and usestower-http
for filesystem serving functions.I've manually tested serve with the
test_book
:I can't guarantee though that there are no regressions. I did not find integrations tests for the serve command.