Skip to content

Only print the pruning note if the trace was definitely pruned #1989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2022

Conversation

saethlin
Copy link
Member

Per #1987 (comment)

The only problem with this is that it looks like we can't emit the note about -Zmiri-backtrace=full if we also emit a tag-tracking diagnostic. The final note about the setting simply doesn't appear on the final error if it is printed before. I feel like we're running up against some diagnostic deduplication logic?

@RalfJung
Copy link
Member

I feel like we're running up against some diagnostic deduplication logic?

Yeah, sounds plausible.
An alternative might be to not emit this as a separate diagnostic, but attach it to the backtrace diagnostic instead? Doesn't seem very important though.

@bors r+

@bors
Copy link
Contributor

bors commented Feb 26, 2022

📌 Commit f1c6498 has been approved by RalfJung

@bors
Copy link
Contributor

bors commented Feb 26, 2022

⌛ Testing commit f1c6498 with merge b490e6b...

@saethlin
Copy link
Member Author

attach it to the backtrace diagnostic instead?

I don't like how this tucks it away. And the notes we display like this are mostly relevant to particular frames, not the backtrace overall, and they are formatted as such.

@bors
Copy link
Contributor

bors commented Feb 26, 2022

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing b490e6b to master...

@bors bors merged commit b490e6b into rust-lang:master Feb 26, 2022
@saethlin saethlin deleted the short-backtraces branch May 15, 2022 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants