Grammar for tuple and tuple indexing expressions #263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewjasper
requested changes
Mar 11, 2018
src/expressions/tuple-expr.md
Outdated
| @@ -22,6 +29,10 @@ comma: | |||
|
|
|||
| ## Tuple indexing expressions | |||
|
|
|||
| > **<sup>Syntax</sup>** | |||
| > _TupleIndexingExpression_ : | |||
| > [_Expression_] `.` [INTEGER_LITERAL] | |||
There was a problem hiding this comment.
This can be TUPLE_INDEX
There was a problem hiding this comment.
Fixed. That's correct, but it's like the lexer is aware of context... which is strange. But yeah, the parser is the one that disallows prefixes, suffixes and nonzero numbers beginning in zero.
src/expressions/tuple-expr.md
Outdated
| > `(` `)` | ||
| > | `(` [_Expression_] `,` `)` | ||
| > | `(` [_Expression_] (`,` [_Expression_] )<sup>\+</sup> | ||
| > `,`<sup>?</sup> `)` |
There was a problem hiding this comment.
These two can be merged into `(` [_Expression_] `,` `)` <sup>\+</sup> [_Expression_]<sup>?</sup> `)`
- use the TUPLE_INDEX token - compacted the TupleExpression
matthewjasper
approved these changes
Mar 12, 2018
|
Thanks again. 💟 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.