Fix the definition of MetaItem and MetaSeq #330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current definitions mean that the following are valid attributes: - `#[foo(,)]` - `#[foo(, , , , ,)]` These aren't (intended to be) valid. This fixes the definitions to only allow an EMPTY at the end of a comma-separated list.
Havvy
requested changes
May 9, 2018
MetaSeq's definition makes this unnecessary
|
@Havvy Good catch. Done. |
Havvy
approved these changes
May 9, 2018
|
💟 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current definitions mean that the following are valid attributes:
#[foo(,)]#[foo(, , , , ,)]These aren't (intended to be) valid. This fixes the definitions to only allow an EMPTY at the end of a comma-separated list.