Skip to content

[RFC 231] Capture mode and closure trait rules #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2018

Conversation

crlf0710
Copy link
Member

I always have to open RFC 231 to check when i need to explain these rules to others
So i copied these text (with minimal editorial changes) from RFC 231 to The Rust Reference so people can read them more easily.

@Havvy
Copy link
Contributor

Havvy commented Jul 15, 2018

I'm too tired to properly review this, but this is definitely the kind of improvements I like to see. 😄

@alercah
Copy link
Contributor

alercah commented Jul 15, 2018

Thanks! There's a fair bit of this content already on the closure types page, can you please make sure that it isn't redundant?

@crlf0710
Copy link
Member Author

@alercah Oops, i somehow overlooked those text. So I replaced my patch with just adding a heading there and linked to it. How does that look?

@alercah
Copy link
Contributor

alercah commented Jul 15, 2018

Looks good! I had some WIP on fixing up this section to be more consistent overall with the types section, but I lost the computer it was on, and this is a definite improvment! If you want to try to work more in this space and get the two meshing better, go for it. 👍

Thanks for the PR! ❤️

@alercah alercah merged commit 24f4e32 into rust-lang:master Jul 15, 2018
@crlf0710 crlf0710 deleted the patch-1 branch July 15, 2018 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants