Skip to content

Grammar: types #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 6, 2018
Merged

Grammar: types #433

merged 3 commits into from
Oct 6, 2018

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Sep 25, 2018

No description provided.

@ehuss
Copy link
Contributor Author

ehuss commented Sep 25, 2018

One rule (FunctionParametersMaybeNamedVariadic) is blocked on #430. EDIT: Updated.

I was thinking it might be a good idea to split the types chapter into multiple subchapters. If you want, I can do that after this is done.

Copy link
Contributor

@matthewjasper matthewjasper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I don't think that Type and TypeNoBounds are quite correct, everything else looks good.

src/types.md Outdated
> _TupleType_ :\
>       `(` `)`\
>    | `(` [_Type_] `,` `)`\
> &nbsp;&nbsp; | `(` [_Type_]&nbsp;( `,` [_Type_] ) <sup>+</sup> `,`<sup>?</sup> `)`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two could be combined as ( ( Type , ) + Type ? )

src/types.md Outdated
<!--
What else should be said here?
The only documentation I am aware of is https://rust-lang-nursery.github.io/rustc-guide/type-inference.html
Should there be a broader discussion of type inference somewhere?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, eventually.

@matthewjasper
Copy link
Contributor

Thanks again!

@matthewjasper matthewjasper merged commit 6a5a823 into rust-lang:master Oct 6, 2018
@ehuss ehuss mentioned this pull request Oct 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants