Skip to content

Fix typo in a procedural-macros example. #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2018
Merged

Fix typo in a procedural-macros example. #457

merged 1 commit into from
Oct 23, 2018

Conversation

chaoticlonghair
Copy link
Contributor

@chaoticlonghair chaoticlonghair commented Oct 23, 2018

  1. ' -> "
  2. parameter name is not right, input is input, but item is used
  3. link for [union] is not existed, it should be [unions] (in the last line of that file)

@@ -114,7 +114,7 @@ as `make_answer!{}`, `make_answer!();` or `make_answer![];`.
### Derive mode macros

*Derive mode macros* define new modes for the `derive` [attribute]. These macros
define new [items] given the token stream of a [struct], [enum], or [union].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the link ref at the bottom, not the prose. The prose has the correct plurality here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, i push again.
since this pr is so easy, i just push --force to combine commits.

@Havvy
Copy link
Contributor

Havvy commented Oct 23, 2018

The other two changes and the whitespace changes are good.

Copy link
Contributor

@Havvy Havvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 💟

@Havvy Havvy merged commit 24d7318 into rust-lang:master Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants