Skip to content

Fix some grammar issues. #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 18, 2018
Merged

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Nov 16, 2018

  • trait was missing bounds.
    trait T: Clone {}
  • Type for const in trait is not optional.
    trait T {
        const C = 1;  // INVALID
        const C2: i32 = 1;
    }
  • Associated type in trait can have a bare ::
    trait T { type X:; }
  • Visibility is not needed on UseDeclaration, it is part of Item.
  • : in generic lifetime param was missing parenthesis grouping to make it optional.
    fn f<'a>() {}

Copy link
Contributor

@matthewjasper matthewjasper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, there's a couple more things that could be fixed in these files if you have time.

@matthewjasper
Copy link
Contributor

Thanks!

@matthewjasper matthewjasper merged commit 81964af into rust-lang:master Nov 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants