Skip to content

"Improve language in 'Constant Expressions'. #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 3, 2019

Conversation

chriskrycho
Copy link
Contributor

@chriskrycho chriskrycho commented Jan 3, 2019

Fixes #497.

Copy link
Contributor

@Centril Centril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tomorrow came quickly... ;)

Some suggestions:

@chriskrycho
Copy link
Contributor Author

Yeah, I realized I was more motivated to push this than to clean the dishes! 😆

@Centril
Copy link
Contributor

Centril commented Jan 3, 2019

Haha; I sympathize with not cleaning the dishes ;)

This turned out great; thanks!

@Centril Centril merged commit 692f694 into rust-lang:master Jan 3, 2019
@chriskrycho chriskrycho deleted the const-evaluation-467 branch January 3, 2019 03:45
@chriskrycho
Copy link
Contributor Author

My pleasure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants