Make Name hold escaped name
#12993
Merged
Make Name hold escaped name
#12993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lowr
commented
Aug 10, 2022
Comment on lines
+2235
to
+2267
| mod r#mod { | ||
| #[test] | ||
| fn r#fn() {} | ||
|
|
||
| /// ``` | ||
| /// ``` | ||
| fn r#for() {} | ||
|
|
||
| /// ``` | ||
| /// ``` | ||
| struct r#struct<r#type>(r#type); | ||
|
|
||
| /// ``` | ||
| /// ``` | ||
| impl<r#type> r#struct<r#type> { | ||
| /// ``` | ||
| /// ``` | ||
| fn r#fn() {} | ||
| } | ||
|
|
||
| enum r#enum {} | ||
| impl r#struct<r#enum> { | ||
| /// ``` | ||
| /// ``` | ||
| fn r#fn() {} | ||
| } | ||
|
|
||
| trait r#trait {} | ||
|
|
||
| /// ``` | ||
| /// ``` | ||
| impl<T> r#trait for r#struct<T> {} | ||
| } |
There was a problem hiding this comment.
This is by far the best Rust code I've ever written.
|
@bors r+ |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #12787
Resolves rust-lang/rust#99361
This PR effectively swaps
NameandEscapedNamein hir. In other words, it makesNamehold and print escaped raw identifiers and introduces another structUnescapedNamefor cases where you need to print names without "r#" prefix.My rationale is that it makes it easier for us to format an escaped name into string, which is what we want when we serialize names in general. This is because we format a name into string usually when we are presenting it to the users and arguably they expect its escaped form as that's what they see and write in the source code.
I split the change for
Nameinto 3 commits to make it easier to follow but it also made some tests fail in the intermediate commits. I can squash them into a commit after the review if desired. I've also made similar changes forModPathandEscapedModPathas it makes them consistent withName.For reference, there was a brief discussion on this in a zulip thread.