Use ZWNJ to prevent VSCode from forming ligatures between hints and code #13886
Conversation
rustbot
added
the
S-waiting-on-review
|
@bors r+ |
|
☀️ Test successful - checks-actions |
|
Hmm, so this doesn't seem to actually work, though I am pretty sure it worked in my local testing ... |
|
Turns out this never fixed it, using a different theme worked for some reason ... |
|
Something about inline type inlays changed recently, was it caused by this? Used to, when clicking on the text of the inlay, a block style cursor would select the whole inlay as if it were a character, but now the cursor goes on top of the character to the left of the inlay, which is annoying because it is visually identical to the cursor being on the character to the left, and you can't immediately tell if the cursor is on the left or right. |
|
I believe that might be due to #13699, but I'll revert this PR anyways since it doesn't actually seem to work (I just got fooled by the default theme). |
Revert "Use ZWNJ to prevent VSCode from forming ligatures between hints and code" Doesn't actually seem to fix the bug, it seems to be theme dependent and I am not sure what causes it Reverts #13886
Turns out VSCode still has this issue for native hints as well, cc #6236