Skip to content

fix: Don't pass feature flags to rustc private crates metadata invocation #14357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Mar 15, 2023

Fixes #14327

Better error reporting I'll do in a follow up

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 15, 2023
@Veykril
Copy link
Member Author

Veykril commented Mar 15, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Mar 15, 2023

📌 Commit 8b8cd04 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Mar 15, 2023

⌛ Testing commit 8b8cd04 with merge 579797f...

@bors
Copy link
Contributor

bors commented Mar 15, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 579797f to master...

1 similar comment
@bors
Copy link
Contributor

bors commented Mar 15, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 579797f to master...

@bors
Copy link
Contributor

bors commented Mar 15, 2023

👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request.

@bors bors merged commit 579797f into rust-lang:master Mar 15, 2023
@Veykril Veykril deleted the rustc-priv branch March 25, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't apply rust-analyzer.cargo.features to rustc private crates
3 participants