Skip to content

feat: IDE support for asm! expressions #18022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 5, 2024
Merged

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Sep 1, 2024

Fixes #10461, Fixes #6031 Progresses #11621

Notably this only works for asm expressions not items yet. Most IDE features work, mainly completions need extra logic still.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 1, 2024
@Veykril Veykril force-pushed the asm-parse branch 2 times, most recently from 6b7c389 to cd391bb Compare September 1, 2024 11:47
@Veykril Veykril changed the title Parse builtin#asm expressions More support for asm! Sep 1, 2024
@bors
Copy link
Contributor

bors commented Sep 4, 2024

☔ The latest upstream changes (presumably #18045) made this pull request unmergeable. Please resolve the merge conflicts.

@Veykril Veykril changed the title More support for asm! More support for asm! Sep 5, 2024
@Veykril Veykril marked this pull request as ready for review September 5, 2024 11:45
@Veykril
Copy link
Member Author

Veykril commented Sep 5, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Sep 5, 2024

📌 Commit c075a99 has been approved by Veykril

It is now in the queue for this repository.

@Veykril Veykril changed the title More support for asm! feat: IDE support for asm! expressions Sep 5, 2024
@bors
Copy link
Contributor

bors commented Sep 5, 2024

⌛ Testing commit c075a99 with merge d927daf...

@bors
Copy link
Contributor

bors commented Sep 5, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing d927daf to master...

@bors bors merged commit d927daf into rust-lang:master Sep 5, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
3 participants