internal: Remove crate graph deduplication logic #18080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
Not opposed to the removal, but what's the thinking, if you don't mind my asking? |
|
Cargo runs proc macros in the workspace directory, not the crate manifest
dir, which we need to replicate and as such all crates are unique wrt to
their workspace. Cargo also will expose this in an env var in the future
(if it doesn't already on stable)
…On Tue, Sep 10, 2024, 10:56 PM David Barsky ***@***.***> wrote:
Not opposed to the removal, but what's the thinking, if you don't mind my
asking?
—
Reply to this email directly, view it on GitHub
<#18080 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA4VNS7247BSBUCZ43QJEETZV5MGTAVCNFSM6AAAAABN4NXYP2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBRHE4TIOJWGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Veykril
force-pushed
the
dedup
branch
2 times, most recently
from
659d5f2 to
8753c7a
Compare
|
@bors r+ |
|
☀️ Test successful - checks-actions |
|
Thanks @Veykril ! |
lnicola
changed the title
|
This should hopefully fix it for good now |
LHolten
added a commit
to LHolten/rust-analyzer
that referenced
this pull request
Dec 31, 2024
LHolten
added a commit
to LHolten/rust-analyzer
that referenced
this pull request
Dec 31, 2024
LHolten
added a commit
to LHolten/rust-analyzer
that referenced
this pull request
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17748