fix: Fix type argument mismatch incorrectly triggering on inferred trait args #19675
+29
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
Please don't merge this yet. I want to review this. |
|
Im fine with closing this in favor of yours. This was also meant as a quick and dirty fix for the time being. |
|
So it appears there are more places that we incorrectly don't forward |
|
Cool go ahead |
|
Okay I did this. I think I covered all places. |
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Previously this being incorrect wasn't a problem, it just meant we put an error type that then changed to infer type, so exactly what rustc does at the end. But now there is a diagnostic.
Veykril
force-pushed
the
push-uuluymsosttr
branch
from
72ee94f to
e9fc3b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19669