internal: More shrink_to_fit() and upgrade dashmap and hashbrown
#19688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This saves 18mb on `analysis-stats .`, without regressing speed.
And adapt `intern` to the changes in the API.
It's the intended use.
rustbot
added
the
S-waiting-on-review
Veykril
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My secret crystal ball told me there are places we still don't
shrink_to_fit(). Well, almost a crystal ball. My crystal ball is the memory profiling I implemented for Salsa (very rudimentary right now, but I do plan to polish and release it). This saves 18mb. Speed doesn't regress.Also packed with an upgrade to dashmap and hashbrown, because I thought this will be related (it won't). My crystal ball was wrong about this one, apparently.