"clippy-driver -Vv" is different from "clippy-driver --version --verbose"

[jsgf]

These two invocations produce the same output:

$ clippy-driver -V
clippy 0.0.212 (69f99e7 2019-12-14)
$ clippy-driver --version
clippy 0.0.212 (69f99e7 2019-12-14)

But these do not. Assuming that -v is the short form for --verbose, I would expect them to be equivalent. I would also expect -Vv to be the same as -V -v.

$ clippy-driver -Vv
rustc 1.41.0 (5e1a79984 2020-01-27)
binary: rustc
commit-hash: 5e1a799842ba6ed4a57e91f7ab9435947482f7d8
commit-date: 2020-01-27
host: x86_64-unknown-linux-gnu
release: 1.41.0
LLVM version: 9.0
$ clippy-driver --version --verbose
clippy 0.0.212 (69f99e7 2019-12-14)
[jsgf@jsgf-fedora-R90S9GAX rustversion]$ clippy-driver -V -v
clippy 0.0.212 (69f99e7 2019-12-14)

Is this intended? It's very confusing.

[jsgf]

It seems to be a side-effect of: https://github.com/rust-lang/rust-clippy/blob/master/src/driver.rs#L302-305

            if orig_args.iter().any(|a| a == "--version" || a == "-V") {
                let version_info = rustc_tools_util::get_version_info!();
                println!("{}", version_info);
                exit(0);
            }

as -Vv misses this check and is passed through to rustc.

This means that -Vg has a similar effect:

$ clippy-driver -Vg
rustc 1.41.0 (5e1a79984 2020-01-27)

This makes it look very much like an accident than an intended behaviour.

[phansch]

@matthiaskrgr do you remember if this issue was resolved with #5178?

[matthiaskrgr]

Seems like nothing changed here.
I'm not sure how clippy-driver prints the rustc version info on -vV.

[matthiaskrgr]

Oh wait, the PR changed something about --rustc didn't it?
clippy-driver --version .* prints clippy 0.0.212 (1f5bc17 2020-12-19) but you can always get the rustc version info with
clippy-driver --rustc --version or clippy-driver --rustc --version --verbose

[flip1995]

The behavior with -vV is still not fixed. Though it doesn't really matter, because the Clippy commit and date is the same as rustc -V, since we're using subtree