Skip to content

Fix i686-unknown-linux-gnu CI job #11466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Conversation

Alexendoo
Copy link
Member

When testing oli-obk/ui_test#161 I gave --ignored a try, I was surprised to see many of the 32bit tests passing even though I'm on a 64bit target

Turns out the .stderrs were incorrect, and our i686-unknown-linux-gnu job has been running x86_64-unknown-linux-gnu so it didn't get picked up

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Sep 6, 2023

r? @dswij

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 6, 2023
@Alexendoo
Copy link
Member Author

r? @flip1995 for CI (thought it did that automatically)

@rustbot rustbot assigned flip1995 and unassigned dswij Sep 6, 2023
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for investigating and fixing this!

@flip1995
Copy link
Member

flip1995 commented Sep 6, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Sep 6, 2023

📌 Commit 60ffff0 has been approved by flip1995

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Sep 6, 2023

⌛ Testing commit 60ffff0 with merge 69fcbfd...

@bors
Copy link
Contributor

bors commented Sep 6, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 69fcbfd to master...

@bors bors merged commit 69fcbfd into rust-lang:master Sep 6, 2023
@Alexendoo Alexendoo deleted the ci-32bit branch September 6, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants