Skip to content

docs(explicit_write): add missing backtick to complete code snippet #11920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

KisaragiEffective
Copy link
Contributor

close #11918

Please write a short comment explaining your change (or "none" for internal only changes)

changelog: [explicit_write]: add missing backtick to document to complete code snippet

@rustbot
Copy link
Collaborator

rustbot commented Dec 3, 2023

r? @xFrednet

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 3, 2023
@KisaragiEffective KisaragiEffective changed the base branch from stable to master December 3, 2023 23:05
@glmdgrielson
Copy link

Well, that was quick.

@xFrednet
Copy link
Member

xFrednet commented Dec 4, 2023

LGTM, thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Dec 4, 2023

📌 Commit a3ce379 has been approved by xFrednet

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Dec 4, 2023

⌛ Testing commit a3ce379 with merge 1b125f7...

bors added a commit that referenced this pull request Dec 4, 2023
docs(explicit_write): add missing backtick to complete code snippet

close #11918

*Please write a short comment explaining your change (or "none" for internal only changes)*

changelog: [`explicit_write`]: add missing backtick to document to complete code snippet
@bors
Copy link
Contributor

bors commented Dec 4, 2023

💔 Test failed - checks-action_test

@xFrednet
Copy link
Member

xFrednet commented Dec 4, 2023

An integration test is broken. This is not caused by you, I believe someone is working on the fix. Once it works again, I'll r+ this again :)

@xFrednet
Copy link
Member

xFrednet commented Dec 5, 2023

@bors retry

@xFrednet xFrednet added S-waiting-on-bors Status: The marked PR was approved and is only waiting bors and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Dec 5, 2023
@bors
Copy link
Contributor

bors commented Dec 5, 2023

⌛ Testing commit a3ce379 with merge 3a17b70...

bors added a commit that referenced this pull request Dec 5, 2023
docs(explicit_write): add missing backtick to complete code snippet

close #11918

*Please write a short comment explaining your change (or "none" for internal only changes)*

changelog: [`explicit_write`]: add missing backtick to document to complete code snippet
@bors
Copy link
Contributor

bors commented Dec 5, 2023

💔 Test failed - checks-action_test

@xFrednet
Copy link
Member

xFrednet commented Dec 5, 2023

@bors retry

@bors
Copy link
Contributor

bors commented Dec 5, 2023

⌛ Testing commit a3ce379 with merge c8b5aed...

bors added a commit that referenced this pull request Dec 5, 2023
docs(explicit_write): add missing backtick to complete code snippet

close #11918

*Please write a short comment explaining your change (or "none" for internal only changes)*

changelog: [`explicit_write`]: add missing backtick to document to complete code snippet
@xFrednet
Copy link
Member

xFrednet commented Dec 5, 2023

It looks like bors is hanging. The CI should be fixed after the next sync in #11929

@bors r-

@matthiaskrgr
Copy link
Member

@bors force

something is weird

@bors
Copy link
Contributor

bors commented Dec 5, 2023

💥 Test timed out

@matthiaskrgr
Copy link
Member

@bors r=xFrednet

@bors
Copy link
Contributor

bors commented Dec 5, 2023

📌 Commit a3ce379 has been approved by xFrednet

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Dec 5, 2023

⌛ Testing commit a3ce379 with merge 42b017d...

@bors
Copy link
Contributor

bors commented Dec 5, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing 42b017d to master...

@bors bors merged commit 42b017d into rust-lang:master Dec 5, 2023
@KisaragiEffective KisaragiEffective deleted the patch-2 branch December 5, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: The marked PR was approved and is only waiting bors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in explicit_write docs
6 participants