Avoid deleting labeled blocks #12219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @blyxyas (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
y21
reviewed
Feb 1, 2024
blyxyas
reviewed
Feb 1, 2024
tests/ui/unnecessary_operation.rs
Outdated
There was a problem hiding this comment.
This should be in tests/ui/no_effect.rs 🐱
There was a problem hiding this comment.
Why? The test case triggers unnecessary_operation, not no_effect.
There was a problem hiding this comment.
Oh yeah, I misread something, it's ok.
blyxyas
approved these changes
Feb 3, 2024
blyxyas
force-pushed
the
labeled-block
branch
from
976c360 to
abced20
Compare
|
@bors r+ |
bors
added a commit
that referenced
this pull request
Feb 3, 2024
Avoid deleting labeled blocks Fix #11575. changelog: [`unnecessary_operation`]: skip labeled blocks
|
💔 Test failed - checks-action_test |
|
@bors retry |
bors
added a commit
that referenced
this pull request
Feb 3, 2024
Avoid deleting labeled blocks Fix #11575. changelog: [`unnecessary_operation`]: skip labeled blocks
|
💔 Test failed - checks-action_test |
|
@bors retry |
bors
added a commit
that referenced
this pull request
Feb 3, 2024
Avoid deleting labeled blocks Fix #11575. changelog: [`unnecessary_operation`]: skip labeled blocks
|
💔 Test failed - checks-action_test |
|
@bors retry |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11575.
changelog: [
unnecessary_operation]: skip labeled blocks